Ok, did you copy the new M84.m1s macro to your macros folder - it will not work without this.
Next, the parameters must be in the right order.
P = Pitch
Q = thread depth
R = speed feed
S = speed retract
Next, I am not using feedback, in spindle I am only using "use spindle feedback in sync modes" - i found closed loop/PID not to work very well.
Dave