Now I have these other issues:

- The Cycle Start panel button doesn't work
- The Feed Hold panel button doesn't work
- Tool changes don't work (might be a case of a missing macro file)
- The cycle start UI button is behaving oddly
- Entering in tool offsets from the UI does not change the DRO
- UI jog buttons do not work
- There's an indicated 0.010 wear offset that I cannot clear
- Tool table wear does nothing
- On one homing sequence, the UI put up "Homing Complete" after it homed to X, then homed Z but ignored the home switch, necessitating an EStop. After restarting and jogging off the switch, a second attempt worked fine

...and that's just the issues I found so far.

Can you post your profile and screenset including required modules?

I thought tool wear was only enabled on Mach4 Industrial, do you have an industrial licence? I could be wrong though...
Homing is all related to the ESS and the plugin.. does Warp9 have a working plugin for 5310? Their documentation site is still saying they had problems with build 5000 onwards

Thanks

> Can you post your profile and screenset including required modules?

Can you describe what files you want for "my profile"?

The screenset is the new wxLathe. The only thing I have changed is I deleted the screen button/light for "spindle reverse" (as my spindle doesn't run backwards) and I have added my Lua code to the screen run script.

> I thought tool wear was only enabled on Mach4 Industrial, do you have an industrial licence? I could be wrong though...

I have a hobby licence. Tool wear may not be implemented, but there is a screen widget for it, and it has a value in it (that I cannot change). Presumably it is being applied, or it would be "0".

> Homing is all related to the ESS and the plugin.. does Warp9 have a working plugin for 5310? Their documentation site is still saying they had problems with build 5000 onwards

They do.

From the Warp 9 Forum:

Here is a link to a plugin that has the proper code to work with the v5000 versions of Mach4. Technically it goes back a little further than that, but some other changes to Mach4 made v5000+ behave badly and that is when it was noticed. I believe it was a timing issue, and v5000+ had improved performance which created the problem. It has to do with how the device reports to Mach that it has stopped moving. Every motion control plugin had issues with this except for the ones that Steve Murphree of Artsoft wrote (of course he knew how it was supposed to work!).
Because I know there are issues with the Mach versions leading up to v5305, I set a cutoff date in the plugin. You can ignore the warning if you want to use an older version such as v5036 (I never used that version). I would use v5305 or later.

https://warp9td.com/files/Plugins/ESS/Mach4/ESS_Mach4_v306.zip

Here is where you can download the latest Mach4 installers:

https://www.machsupport.com/ftp/Mach4/DevlopmentVersions/

Please let me know of any bug reports. I am unsure about Height Control. I will definitely be looking at that closely this week.

As far as I can tell (I have not tested it extensively) this combination of ESS 306 and Mach 4 5310 works fine with mill. But the upgrade from 4498 introduced a new lathe screen set with extensive changes and that is the source of the trouble.

If you go to Help>Support>Package Current Profile and upload the file it creates. This will include the screenset, macros, and the machine.ini file

I had a quick look at the tool wear in the default lathe screen. The DRO is set to read only, hence why you can't edit it, also the code in the On Modify script needs updating.  There's a bunch of other changes required to the X and Z offset DRO's too. Looks like DRO names were updated but the code is still referencing the old names   

> If you go to Help>Support>Package Current Profile and upload the file it creates. This will include the screenset, macros, and the machine.ini file

OK, will do. I'll post it later today, thanks.

> Looks like DRO names were updated but the code is still referencing the old names

I'll bet something similar is going on with the screen jog buttons too.

Here you go.

Thanks again.

Here is an updated screen, I've renamed it so it won't overwrite your current screen, you can just load it through the View menu once it's copied to the Screens folder.

This should fix the wear DRO, X and Z tool offset buttons, UI jog buttons, your control panel Cycle Start and Feedhold buttons. I've tried to keep your code the same as much as possible so it's familiar to you but some of it could be optimised. I've tested with the Sim and it looks ok, but always test cautiously on the machine!

I've not changed anything to do with the your pendant stuff. I think it could do with recoding to utilise the signal library to prevent it unnecessarily running functions every time a switch state is changed.

A question regarding your pendant, does the 'Off' setting have it's own signal or are you saying it's considered off when there is no axis selected or speed selected?

Thanks

Wow, that was fast. And on a Saturday too!

>  but some of it could be optimized.

Oh, no doubt.

My prime concern is that the code never fails is a way that does something undefined or dangerous. Uncommanded movements, movements faster than expected or in the wrong direction, etc.

And you are looking at the remnants of my first generation Lua coding. The lathe control panel was the first Lua I ever wrote, and my understanding of the language and how Mach works has gotten slightly better since then. I have some code for tool-length-probe on toolchange for mill in another thread - a project that got derailed by the lathe shenanigans.

> I think it could do with recoding to utilize the signal library to prevent it unnecessarily running functions every time a switch state is changed.

I'm listening. Where is this documented?

> A question regarding your pendant, does the 'Off' setting have it's own signal or are you saying it's considered off when there is no axis selected or speed selected?

For jog?

The jog section of the panel has 3 controls:

- an MPG handle
- an axis select switch, two positions, SPDT, with lines for each axis (X, Z)
- a rotary select switch, 4 positions, 3 lines, OFF (no lines connected) 0.001 (line 1 connected) 0.010 (line 2 connected) 0.100 (line 3 connected)

The reason why there is no "off line" is because I wanted JOG ENABLE to fail OFF if the panel was unplugged or a line broke

The "so what" there is that the function that handles turning on jogging must handle not just the line going ON (to turn jog active) but also OFF (to turn jog inactive). So the fact that Mach calls the function on state change is a feature here.

Axis select, in retrospect, could have been a single line - Z if OFF, X if ON, but at the time I was going for positive control - the axis was only selected if its select line was HIGH, so a broken or unplugged cable disabled jogging.

You should see the mill control - I've overloaded the MPG handle. There's not just an axis select switch, there's a handle function select switch: JOG - SPINDLE OVERRIDE - FEED OVERRIDE. In jog mode the handle jogs like the lathe. In SPINDLE mode the handle changes the spindle speed up or down, and in FEED mode the handle changes the feed speed up or down. And there are separate lights to indicate if the handle is active in JOG mode, or active in SPEED mode...

Anyway, thanks for the fixes - I'll try them tomorrow.

Some quick tests:

1. Wear offset is editable. Check.

2. Tool change works and applies offset. Check.

3. Tool offset is applied and changes DRO. Check.

4. Cycle Start panel button works. Check.

5. Jog buttons on UI work. Not at first. Enabling machine"ungreyed" the panel, but the buttons would not highlight on mouseover. Then they did, and I don't know what triggered that. Incremental step change button works. Speed slider works. Axes work. Button jog mode button does NOT work (always continuous)

Good progress, thanks!

This should fix the jog mode selection