Hello Guest it is April 27, 2024, 12:40:47 AM

Author Topic: Return tool to tool holder when finish working.  (Read 3905 times)

0 Members and 1 Guest are viewing this topic.

Re: Return tool to tool holder when finish working.
« Reply #10 on: April 29, 2023, 12:17:58 PM »
Here is the latest version of the macro.

Hi, i tried a lot of things i don't find the solution for read inputs can you correct me this part for see what part i don't understand?
I want to read the input of the collet and open collet and put some security if something fail.

Code: [Select]
'--------------------------------------------------------------------------
Sub PutToolInRack
'Fisrt check if any tool are inside (maybe i made a manual tool change with an independent button i have in the cnc for make manual tool changes)
If Not IsActive(ToolInside) Then
Message("The spindle doesn't have tool inside! and mach3 think i have a tool loaded!!")   'stop the program if i donesnt have tool and mach3 think i have a tool inside
End If

Else 'continue main code
Code "G00 G53 Z" & ZSafe                'Move to Z axis safe
Call WaitMove(100) 'Wait for finish moving to Zsafe
ActivateSignal(ToolRack) 'Activate the pneumatic tool holder
Call ToolPos (OldTool,XPos, Ypos, ZPos) 'Get rack position
Code "G53 X" & Xpos & " Y" & YPosSlide 'Move to sliding position
Call WaitMove(100)
Code "G01 G53 Z" & Zpos & " F" & FFeed 'Move spindle down
Call WaitMove(100)
Code "G53 Y" & Ypos    'Slide tool into rack
Call WaitMove(100)
ActivateSignal(DrawBar) 'Activate the drawbar and release the tool
Sleep(1000) 'Wait 1 second for open the drawbar
Code "G00 G53 Z" & ZSafe 'Move to safe tool height
Call WaitMove (100)
DeActivateSignal(DrawBar)               'Clamp drawbar (without wait for close the collet because it's not needed here).
DeActivateSignal(ToolRack)              'Return tool rack to retract position
'Check if the tool are droped at toolrack
If Not IsActive(ToolInside) Then 'If the collet  doesn't have a tool inside continue main program, but if tool still are inside STOP!!!
Sleep(1000)
Message("Tool number [Tool #" & OldTool & "] aren in tool rack")   'Only for debug and more info
Else
Message("The spindle still have tool inside!!")   '
Sleep(1000)
Exit Sub
End If
'continue main code
Sleep(250)
SpindleEmpty = 0                        'No tool in spindle
End Sub

'------------------------------------------------------------------------

Thanks and sorry for all inconveniences.
Re: Return tool to tool holder when finish working.
« Reply #11 on: May 02, 2023, 10:31:51 AM »
Bufff, 3 days trying every try i think i make it worse.

If someone can give me some light for take me to the correct path i will be very grateful (and i share all macros with different variants here for all people need it).


Thanks 4 all :)

Offline TPS

*
  •  2,505 2,505
    • View Profile
Re: Return tool to tool holder when finish working.
« Reply #12 on: May 03, 2023, 03:01:25 AM »
would be helpfull if you post your complete macro code, not only a Sub,
and explain what exactly is not working.
anything is possible, just try to do it.
if you find some mistakes, in my bad bavarian english,they are yours.
Re: Return tool to tool holder when finish working.
« Reply #13 on: May 03, 2023, 03:30:37 AM »
would be helpfull if you post your complete macro code, not only a Sub,
and explain what exactly is not working.

Hi and thanks, i post one of my modifications and the working one basic macro.

Basically in my code i made something wrong and never start. I want to understand what i do wrong with this "if, elses,ends..."

I added lines read 2 inputs of mach3, for stop program if collet of atc doesn't open or see if a tool is inside and continue or stop.

I only changed from the original code 2 variables at start of the macro (i don't know if i need to add const or without const this variables) and modified the subs for put in toolrack and getfromtool rack (the second one aren't finished because when i test the macro doesn't work).

Sorry for my bad english. And another time thanks for your time.

Offline TPS

*
  •  2,505 2,505
    • View Profile
Re: Return tool to tool holder when finish working.
« Reply #14 on: May 03, 2023, 05:39:57 AM »
in here:
Code: [Select]
Sub GetToolFromRack
'Fisrt check if any tool are inside
If IsActive(ToolInside) Then 'If have a tool inside spindle
Sleep(1000)
Message("The spindle have tool inside! and mach3 think i don't have a tool loaded!!")   '
Sleep(1000)
Exit Sub
Else
'Get tool from rack
Code "G00 G53 Z" & ZSafe                'Move Z axis safe
Call WaitMove(100)
ActivateSignal(ToolRack)
Call ToolPos (NewTool,XPos, YPos, ZPos) 'Get tool position
Code "G53 X" & Xpos & " Y" & YPos 'Move to new tool position
Call WaitMove(100)
ActivateSignal(DrawBar) 'Activate the drawbar (open collet)
ActivateSignal(ToolRack) 'Activate the pneumatic tool holder
Code "G01 G53 Z" & ZPos & " F" & FFeed 'Down to engage the tool
Call WaitMove(100)
DeActivateSignal(DrawBar) 'Clamp the tool
Sleep(2000) 'Wait for tool to clamp
'---check of the sensor for see if the tool are loaded with the sensor of the spindle---
??? If Not IsActive(ToolInside) Then 'If the tool aren't loaded (empty tool rack, maybe i extracted the tool manually and i don't put it in the tool rack)
Sleep(1000)
??? End If

??? Else
Code "G53 Y" & YPosSlide 'Slide out of rack
Code "G00 G53 Z" & ZSafe 'Move to Z safe position
DeActivateSignal(ToolRack) 'Retract the pneumatic toolrack
SpindleEmpty = 1                        'Spindle has tool loaded
???
End Sub


your If Then Else conditions are mixed up.
just a first quick view.
anything is possible, just try to do it.
if you find some mistakes, in my bad bavarian english,they are yours.
Re: Return tool to tool holder when finish working.
« Reply #15 on: May 03, 2023, 01:14:46 PM »
in here:
Code: [Select]
Sub GetToolFromRack
'Fisrt check if any tool are inside
If IsActive(ToolInside) Then 'If have a tool inside spindle
Sleep(1000)
Message("The spindle have tool inside! and mach3 think i don't have a tool loaded!!")   '
Sleep(1000)
Exit Sub
Else
'Get tool from rack
Code "G00 G53 Z" & ZSafe                'Move Z axis safe
Call WaitMove(100)
ActivateSignal(ToolRack)
Call ToolPos (NewTool,XPos, YPos, ZPos) 'Get tool position
Code "G53 X" & Xpos & " Y" & YPos 'Move to new tool position
Call WaitMove(100)
ActivateSignal(DrawBar) 'Activate the drawbar (open collet)
ActivateSignal(ToolRack) 'Activate the pneumatic tool holder
Code "G01 G53 Z" & ZPos & " F" & FFeed 'Down to engage the tool
Call WaitMove(100)
DeActivateSignal(DrawBar) 'Clamp the tool
Sleep(2000) 'Wait for tool to clamp
'---check of the sensor for see if the tool are loaded with the sensor of the spindle---
??? If Not IsActive(ToolInside) Then 'If the tool aren't loaded (empty tool rack, maybe i extracted the tool manually and i don't put it in the tool rack)
Sleep(1000)
??? End If

??? Else
Code "G53 Y" & YPosSlide 'Slide out of rack
Code "G00 G53 Z" & ZSafe 'Move to Z safe position
DeActivateSignal(ToolRack) 'Retract the pneumatic toolrack
SpindleEmpty = 1                        'Spindle has tool loaded
???
End Sub


your If Then Else conditions are mixed up.
just a first quick view.

Thanks for your reply I'm really confused how to manage the if, then, end if and end sub correctly.

I tried to see the problem and changed the end if i finished the endif for separete the two ifs in the sub, now my head say "for what reason one if stay inside the other if..." and i changed the program for make it in two independent if's.

Like:

Code: [Select]
Sub GetToolFromRack
'First check if any tool are inside
If IsActive(ToolInside) Then 'If have a tool inside spindle
Sleep(1000)
Message("The spindle have tool inside! and mach3 think i don't have a tool loaded!!")   'something failed and the spindle aren't empty
Sleep(1000)
Exit Sub
Else
'Get tool from rack 'start getting the tool from toolrack
Code "G00 G53 Z" & ZSafe                'Move Z axis safe
Call WaitMove(100)
ActivateSignal(ToolRack) 'Activate the pneumatic tool holder
Sleedp(500) 'Little wait for wait pneumatic tool holder (toolrack)
Call ToolPos (NewTool,XPos, YPos, ZPos) 'Get tool position
Code "G53 X" & Xpos & " Y" & YPos 'Move to new tool position
Call WaitMove(100)
ActivateSignal(DrawBar) 'Activate the drawbar (open collet)
Code "G01 G53 Z" & ZPos & " F" & FFeed 'Down to engage the tool
Call WaitMove(100)
DeActivateSignal(DrawBar) 'Clamp the tool
Sleep(2000) 'Wait for tool to clamp
End If   'This part is finished and continue with the next checks for continue the tool change

'---check of the sensor for see if the tool are loaded with the sensor of the spindle---
If Not IsActive(ToolInside) Then 'If the tool aren't loaded (empty tool rack, maybe i extracted the tool manually and i don't put it in the tool rack)
Sleep(1000)
End Sub 'Stop all? maybe not's the correct form for stop the program

Else
Code "G53 Y" & YPosSlide 'Slide out of rack
Code "G00 G53 Z" & ZSafe 'Move to Z safe position
DeActivateSignal(ToolRack) 'Retract the pneumatic toolrack
SpindleEmpty = 1                        'Spindle has tool loaded
End If '

End Sub


All help are very appreciated!
« Last Edit: May 03, 2023, 01:30:05 PM by cncwoodprojects »
Re: Return tool to tool holder when finish working.
« Reply #16 on: May 03, 2023, 01:31:12 PM »
Edit: I added the 0.2 version of the code maybe you want it for see it better all code.

For finish all and abort the tool change (stop the macro) what i neeed to use End sub or Exit sub??? (or maybe another thing)
« Last Edit: May 03, 2023, 01:34:48 PM by cncwoodprojects »

Offline TPS

*
  •  2,505 2,505
    • View Profile
Re: Return tool to tool holder when finish working.
« Reply #17 on: May 03, 2023, 02:45:23 PM »
modified your code a bit:

Code: [Select]

'M6 Start, Rack type tool changer with T0 empty tool return
'This macro is made for a ATC with pneumatic tool rack and two sensors in the Spindle (opencollet and closed collet)
'This macro is write by Graham Waterworth from machsupport forum and CncWoodProjects (i learned a lot with Graham it's a profesional programer)
'This macro is FREE and can be modified but can't be sold or used commercially, and mention the creators.
'For the moment this macro is a test but when all working i go to put in a mach3 forum all variables (without sensors, without tool peneumatic and the all in one version).
'Be sure to change the tools positions, inputs and outputs pins corresponding of your machine (every cnc is different).
'First try to test if it's working in the air (put a Zpos above the tools for example in my case my tool rack is in -110 anf for test i used -80 without tool inside).

'--- Variables:------

NewTool = GetSelectedTool()   'Tool required
OldTool = GetCurrentTool()   'Tool in spindle
MaxToolNum = 8 'Maximum number of tools
FFeed = 250                  'Fast feed on and off tool
ZSafe = -5 'Safe Z
DrawBar = Output11 'Output Port of mach3 (open the collet for tool change)
ToolRack = Output12 'Output Port of mach3 for open the output for activate pneumatic tool rack and in future can use this output for raise dust shoe too (at same time if you don't wan't to put an independent output)
Xpos = 0 'X position of tool in rack
YPos = 0 'Y position of tool in rack
ZPos = 0 'Z position of tool in rack
YPosSlide = 264.00 'Safe start for sliding the tool in and out of rack
SpindleEmpty = 0 'Is the spindle empty
'This two variables are for security and see if the tool open and know if a tool is inside
Const OpenColletSensor = 2 'Sensor for see if the collet are openend
Const ToolInside = 1 'Tool are inside the spindle sensor (doesn't work for see if the collet are closed because the sensor only works in some positions of the spindle for see if are closed without tool, but for indicate the tool is inside work in all positions)



'this variables are for future upgrades and are commented
'ToolRackSensor = Input "x"     'When i have time i wan't to add a limit switch for stop the process if the toolrack doesnt move to position (aircompresor off for example).



'-------Security Check: is spindle running? ----
If GetOEMLED (11) Then
Message "Spidnle working STOP the spindle and retry!! ABORT!!!"
Exit Sub
End If



'-------Security check: Is the machine moving? if is moving wait ----
While IsMoving() 'Wait for finish moving
Sleep(100) 'Sleep for avoid cpu consumption
Wend 'continue with the main program




'Check if the requested tool is within range
If OldTool = 0 Then
SpindleEmpty = 0 'No tool in spindle
Else
SpindleEmpty = 1 'Spindle has a tool loaded
End If




'Do we need a new tool
If NewTool = OldTool Then
'I don't need to change tool
Message "Correct Tool already loaded."
Exit Sub
End If

If NewTool = 0 Then
  If SpindleEmpty = 0 Then
  'No tool to put away exit
Else
    'Put tool away
Call PutToolInRack
End If
SetCurrentTool(NewTool) 'Set the NewTool as current tool
Sleep(250) 'Wait for DRO to update
Exit Sub
Else
  If NewTool > MaxToolNum Or NewTool < 0 Then
  'Stop program and exit
    Message "Tool out of range [Tool #" & NewTool & "]"
    Code "M30"
    Exit Sub
Else
  If SpindleEmpty = 0 Then
  'Get new tool
GetToolFromRack
Else
    'Swap tools
Call PutToolInRack
Call GetToolFromRack
End If
SetCurrentTool(NewTool) 'Set the NewTool as current tool
Sleep(250) 'Wait for DRO to update
  End If
End If

End
'--------------------------------------------------------------------------
Sub PutToolInRack
'Fisrt check if any tool are inside (maybe i made a manual tool change with an independent button i have in the cnc for make manual tool changes)
If Not IsActive(ToolInside) Then 'If the collet doesn't have a tool inside
Sleep(1000)
Message("The spindle doesn't have tool inside! and mach3 think i have a tool loaded!!")   'this part i need to polish it because not's necesary to stop the tool change only avoid to put tool in rack because i dont have tool, but for the moment i want to see when i have this problem see what error i made
Sleep(1000)
Exit Sub
Else 'continue main code
Code "G00 G53 Z" & ZSafe                'Move to Z axis safe
Call WaitMove(100) 'Wait for finish moving to Zsafe
ActivateSignal(ToolRack) 'Activate the pneumatic tool holder
Call ToolPos (OldTool,XPos, Ypos, ZPos) 'Get rack position
Code "G53 X" & Xpos & " Y" & YPosSlide 'Move to sliding position
Call WaitMove(100)
Code "G01 G53 Z" & Zpos & " F" & FFeed 'Move spindle down
Call WaitMove(100)
Code "G53 Y" & Ypos    'Slide tool into rack
Call WaitMove(100)
ActivateSignal(DrawBar) 'Activate the drawbar and release the tool
Sleep(1000) 'Wait 1 second for open the drawbar
Code "G00 G53 Z" & ZSafe 'Move to safe tool height
Call WaitMove (100)
DeActivateSignal(DrawBar)               'Clamp drawbar (without wait for close the collet because it's not needed here).
DeActivateSignal(ToolRack)              'Return tool rack to retract position

End If     'This part is finished and can continue to next security check

'Check if the tool are droped at toolrack
If IsActive(ToolInside) Then 'If the collet have a tool inside STOP!!! the tool arent droped
Sleep(1000)
Message("The spindle still have tool inside!!")
Exit Sub

Else    'if tool arent inside all go in right direction
Message("Tool number [Tool #" & OldTool & "] are in tool rack")   'Only for debug and more info
Sleep(1000)
End If

'continue main code
Sleep(250)
SpindleEmpty = 0                        'No tool in spindle
End Sub

'------------------------------------------------------------------------

Sub GetToolFromRack
'First check if any tool are inside
If IsActive(ToolInside) Then 'If have a tool inside spindle
Sleep(1000)
Message("The spindle have tool inside! and mach3 think i don't have a tool loaded!!")   'something failed and the spindle aren't empty
Sleep(1000)
Exit Sub
Else
'Get tool from rack 'start getting the tool from toolrack
Code "G00 G53 Z" & ZSafe                'Move Z axis safe
Call WaitMove(100)
ActivateSignal(ToolRack) 'Activate the pneumatic tool holder
Sleep(500) 'Little wait for wait pneumatic tool holder (toolrack)
Call ToolPos (NewTool,XPos, YPos, ZPos) 'Get tool position
Code "G53 X" & Xpos & " Y" & YPos 'Move to new tool position
Call WaitMove(100)
ActivateSignal(DrawBar) 'Activate the drawbar (open collet)
Code "G01 G53 Z" & ZPos & " F" & FFeed 'Down to engage the tool
Call WaitMove(100)
DeActivateSignal(DrawBar) 'Clamp the tool
Sleep(2000) 'Wait for tool to clamp

'---check of the sensor for see if the tool are loaded with the sensor of the spindle---
If Not IsActive(ToolInside) Then 'If the tool aren't loaded (empty tool rack, maybe i extracted the tool manually and i don't put it in the tool rack)
Sleep(1000)
Message ("No tool in spindle -> Abort")
Sleep(200)
Code "M30" 'stop the program
End If

'we got a tool in spindle so we continue
Code "G53 Y" & YPosSlide 'Slide out of rack
Code "G00 G53 Z" & ZSafe 'Move to Z safe position
DeActivateSignal(ToolRack) 'Retract the pneumatic toolrack
SpindleEmpty = 1                'Spindle has tool loaded
End If '

End Sub



Sub WaitMove(ByVal Dtime As Integer)
  While IsMoving()
    Sleep(Dtime)
  Wend
End Sub

Sub ToolPos(ByVal ToolNumber As Integer, ByRef XPos, ByRef YPos, ByRef ZPos)
'Subroutine to find tool location coordinates
Select Case ToolNumber
Case is = 1 'If the tool number is 1 then read these XYZ positions
Xpos = 112.25 'Here specify  the Machine coords of the tool 1 position.
Ypos = 304.79 'same for all cases
Zpos = -80.00
Case is = 2
Xpos = 212.25
Ypos = 304.79
Zpos = -80.00
Case is = 3
Xpos = 312.25
Ypos = 304.79
Zpos = -80.00
Case is = 4
Xpos = 412.25
Ypos = 304.79
Zpos = -80.00
Case is = 5
Xpos = 512.25
Ypos = 304.79
Zpos = -80.00
Case is = 6
Xpos = 612.25
Ypos = 304.79
Zpos = -80.00
Case is = 7
Xpos = 711.50
Ypos = 304.79
Zpos = -80.00
Case is = 8
Xpos = 111.50
Ypos = 304.79
Zpos = -50.00
End Select
End Sub       


anything is possible, just try to do it.
if you find some mistakes, in my bad bavarian english,they are yours.
Re: Return tool to tool holder when finish working.
« Reply #18 on: May 03, 2023, 03:12:24 PM »
Thanks another time.

I see the problem i understand i only need to know "if is not active this signal " then "stop, abort!" and no else needed for continue if is active this trigger doesn't start and jump to continuation of the macro.

Tomorrow i go to try more and see if other parts need rework directly in the cnc (testing in air, i configured Z in safe heigh and i can "simulate" this situations).

Another time big thanks and if i finish and make it work (or have more problems) i go to post it here.
Re: Return tool to tool holder when finish working.
« Reply #19 on: May 04, 2023, 04:04:05 PM »
I halt the process of the macro i found one issue in my ATC.

The tool sensor for see if i have a tool inside have some issues, when i rotate the spindle manually without a tool inside the sensor triggers active sometimes i think the sensor is moved o too close to the clamp. I contacted to the manufacturer for see how to solve this an pray because a Rattm motor spindle is Chinese and find assistance is difficult (they answer al night for me, and when is day they doesn't work).

IF it's impossible to solve (send to china it's discarted)  i have a ATC without tool sensor, only open clamp sensor because i don't want to disassemble the ATC without a tutorial, video or manual of the same spindle.

With this issue the part of the macro for see if too are inside or not never can work correctly and false triggers are more than possible.
« Last Edit: May 04, 2023, 04:08:41 PM by cncwoodprojects »