Hello Guest it is March 28, 2024, 09:17:02 AM

Author Topic: pplease look at this code  (Read 3980 times)

0 Members and 1 Guest are viewing this topic.

pplease look at this code
« on: May 12, 2012, 02:36:23 PM »
Hello There---

perhaps someone could look at this code and tell me why i am not getting to
subroutine O2 and subroutine O3  ??

regards

fred evans
think of the trees-- use both sides of the computer paper
Re: pplease look at this code
« Reply #1 on: May 12, 2012, 02:52:17 PM »
At line 540 you had a GO (like let's "GO") not G0.... Appears to call subs OK in my backplotter (NC Plot).

See attached....
"It is well that war is so terrible -- lest we should grow too fond of it." Gen. R.E. Lee CSA

The United States Constitution (c) 1791. All Rights Reserved.

Offline BR549

*
  •  6,965 6,965
    • View Profile
Re: pplease look at this code
« Reply #2 on: May 12, 2012, 04:39:15 PM »
Just some tips, ALWAYS use lower case o for the Sub name(o123) once you use it it comes obvious as to why

Either use cap G or lower G but not both

You cannot use  Z-#var  MACH3 will error you must solve the #val as a neg value  such as Z [-1*#3]  YES it does not comform to standard Gcode BUT that is just the way Mach3 does it.  The Z- in this case should indicate a neg DIRECTION call but it does not(;-)

Double check for end brackets on comments

Limit Comments to criticle issues  (;-) Gcode is not a diary. Makes it hard to follow with all the comments jumbling up the code AS mach3 does NOT handle comments correctly for display. It should maintain the Gcode line to comment relationship BUT it just zipps to the end of the comments and stays there.

Correct the notes in the returned file (notes are in the file)  and it should run ok.

(;-) TP
« Last Edit: May 12, 2012, 04:42:15 PM by BR549 »
Re: pplease look at this code
« Reply #3 on: May 15, 2012, 10:02:27 AM »
Thanks chaps-- this is really helping me

762X51  - please tell me how put the line numbers in ?? and formatted all to uppercase??
What is a back plotter ?



And TP - many thanks for the coding tips-- Certain conventions  always to the benefit of the
greater good.

Re z-#3 -- point noted

could it be done as
#3=-18
>
>
>

subroutine starts

go z#3 
??
thanks


So looks like all minor case at all times may be a good habit to develop ? also no comments on blank lines

Commenting kept to a minimum (as soon as I have memorised all the codes)

I have made the changes and it runs right throug- now just to debug and i can do my first job.



think of the trees-- use both sides of the computer paper
Re: pplease look at this code
« Reply #4 on: May 15, 2012, 11:26:33 AM »
Fred,

I use NC Plot http://www.ncplot.com/ and you can format your Gcode as well as display a plot of the tool paths with the program.

Attached is a screen shot...

Orin

"It is well that war is so terrible -- lest we should grow too fond of it." Gen. R.E. Lee CSA

The United States Constitution (c) 1791. All Rights Reserved.
Re: pplease look at this code
« Reply #5 on: May 16, 2012, 10:54:03 AM »
Hello Orin,

thanks for the info. Is NC PLOT a similar type of program to Gwizard??

Why i am asking is that i have started the tutorial in cnc cookbook and find it to be really
good. they are punting their product called gwizard .

your observations are appreciated

regards

fred



think of the trees-- use both sides of the computer paper
Re: pplease look at this code
« Reply #6 on: May 16, 2012, 11:28:58 AM »
Hi Fred,

Yes, Gwizard is a nice program but I didn't like having to buy a "subscription" that has an ongoing annual cost.

Orin
"It is well that war is so terrible -- lest we should grow too fond of it." Gen. R.E. Lee CSA

The United States Constitution (c) 1791. All Rights Reserved.