The only problem I can see is if your home switch is also the limit this could cause mach4 to disable, just as a thought have you thought of using something like mc.mcCntlGcodeExecuteWait(inst, "G0 Z-1 F50") this will halt the gcode.
I have been looking into the mc.mcSignalWait and all works well when using any of the ISIG_INPUT0 to 63 etc but not working on anything else???

DazTheGas

Daz - I mapped the Z home signal to Input_21 and I still can't get mc.mcSignalWait to work? The API says to use the signal handle, are you using the handle?  I haven't tried the others yet.

Current M100:

function M100()
   
    local inst = mc.mcGetInstance()
    local input_20 = mc.mcSignalGetHandle(inst, mc.ISIG_INPUT20) -- Get handle for input 20
    local input_20_State = mc.mcSignalGetState(input_20) -- Get input 20 state
    local z_home_sig = mc.mcSignalGetHandle(inst, mc.ISIG_INPUT21) -- Get handle for Z axis home switch
    --local z_home_sig_state = mc.mcSignalGetState(z_home_sig) --Get state of  signal

    if input_20 == 0 then
        wx.wxMessageBox("Could not locate signal!")

    else

        if input_20_State == 1 then --If input_20_State equals 1, then the signal is active.
            wx.wxMessageBox("Signal is already active!")

        else    --If input_20_State does not equal 1, then the signal is inactive.
            --wx.wxMessageBox("Setting input_20 high")
            mc.mcSignalSetState(input_20, 1)
            mc.mcSignalWait(inst, z_home_sig, WAIT_MODE_HIGH, 20)
        end
    end
end

if (mc.mcInEditor() == 1) then
    M100()
end



I looked at mc.mcCntlGcodeExecuteWait. I don't know how I could use it because the Z axis is not controlled via G-code.

I got mcSignalWait to work.  I was wrong API does not say to use handle.  It worked by putting the signal ID.

Was just looking at that myself.

From the manual......
sigId      A valid signal ID. (NOT a signal handle)

Glad you got it sorted. 

How about post the code that worked so others will see what right looks like.

Here is the code that works:


function M100()
    
    local inst = mc.mcGetInstance()
    local input_20 = mc.mcSignalGetHandle(inst, mc.ISIG_INPUT20) -- Get handle for input 20
    local input_20_State = mc.mcSignalGetState(input_20) -- Get input 20 state
    local z_home_sig = mc.ISIG_INPUT21 -- Get Signal ID for Z axis home switch
    
    if input_20 == 0 then
        wx.wxMessageBox("Could not locate signal!")

    else

        if input_20_State == 1 then --If input_20_State equals 1, then the signal is active.
            wx.wxMessageBox("Signal is already active!")

        else    --If input_20_State does not equal 1, then the signal is inactive.
            --wx.wxMessageBox("Setting input_20 high")
            mc.mcSignalSetState(input_20, 1)
            mc.mcSignalWait(inst, z_home_sig, 1, 0)
        end
    end
end

if (mc.mcInEditor() == 1) then
    M100()
end



Nice, thanks!

Does this work as well?

function M100()
    
    local inst = mc.mcGetInstance()
    local input_20 = mc.mcSignalGetHandle(inst, mc.ISIG_INPUT20) -- Get handle for input 20
    local input_20_State = mc.mcSignalGetState(input_20) -- Get input 20 state
    
    if input_20 == 0 then
        wx.wxMessageBox("Could not locate signal!")

    else

        if input_20_State == 1 then --If input_20_State equals 1, then the signal is active.
            wx.wxMessageBox("Signal is already active!")

        else    --If input_20_State does not equal 1, then the signal is inactive.
            --wx.wxMessageBox("Setting input_20 high")
            mc.mcSignalSetState(input_20, 1)
   mc.mcSignalWait(inst, mc.ISIG_INPUT21, 1, 0)
        end
    end
end

if (mc.mcInEditor() == 1) then
    M100()
end
Also, just wondering what this is.........  mc.mcSignalSetState(input_20, 1)

Shouldn't that be turning on an output to fire the raise solenoid?

Actually I am using input 20 as a "In automatic Cycle" signal. The M100 is interacting with the PLC script to monitor the Z-axis encoder and change direction when necessary.  I am still working on the Z axis reciprocation and automatic grinding cycle part at the moment, but as of now, yes the input 20 is setting the output_1 high in the PLC script which sends the Z axis home.

Yes your sample works also.

yay you lot have been busy, glad its working for you now.

DazTheGas

Is there a simple way to pause motion until an input is triggered within a macro?  

I would like to ensure my Z axis returns home before the macro ends because after the macro would be an X-Y move. This is a cylinder where I have output 1 activate the "up" direction and output 0 activate the "down" direction.  

Something like this:

1. activate output_1 (up)
2. wait for Z home switch to trigger
3. end macro.

What is the best way to code step 2 (wait for input) in a Macro?

Good, thanks for testing!

This does not do any error checking and the time it waits for the input to go high is indefinite (neither of which are very good ideas) and it does not take your "In automatic Cycle" into account but it should be all that is needed to do what you were looking for originally.

Also note the 2 M100's were changed to m100 so should be saved as m100.mcs. Early on their was some debate about whether or not M codes should be upper or lower case in the scripts themselves. The answer is lower case. It should prevent some possible issues in non Windows OS's.

I would also delete any other M100 files (M100.mcs, M100.mcc, M100.bak) each time you edit the macro and before testing. If not, your changes may not take effect until you do.

function m100()
    
    local inst, hSig
    inst = mc.mcGetInstance()
    hSig = mc.mcSignalGetHandle(inst, mc.OSIG_OUTPUT1) -- Get handle for output 1
    
    mc.mcSignalSetState(hSig, 1) --turn on output 1
    mc.mcSignalWait(inst, mc.ISIG_INPUT21, 1, 0) --Wait indefinitely (0) for input 21 to become active
  
end

if (mc.mcInEditor() == 1) then
    m100()
end