Welcome, Guest. Please login or register.
Did you miss your activation email?
July 27, 2017, 01:50:23 AM

Login with username, password and session length
Search:     Advanced search
* Home Help Search Calendar Links Login Register
+  Machsupport Forum
|-+  Mach Discussion
| |-+  VB and the development of wizards
| | |-+  ATC automatic tool change M6 macro Dynomotion Kflop+Kanalog
Pages: « 1 2   Go Down
Print
Author Topic: ATC automatic tool change M6 macro Dynomotion Kflop+Kanalog  (Read 14407 times)
0 Members and 1 Guest are viewing this topic.
stirling
Global Moderator
*
Offline Offline

Posts: 2,189

UK


View Profile WWW
« Reply #10 on: May 10, 2012, 05:00:21 AM »

Hi Jerome

In just a couple of pages of code you've managed to make just about every error it's possible to make - so congratulations for that achievement at least. Just a FEW examples:

Incorrectly scoped variables. Variables that are assigned but never used. Variables that are used but never initialised. Functions that do NOTHING at all. Function return values discarded. Incorrect sub and function call syntax. Bizarre comparison of Boolean values. Inconsistent types. Explicit altering of loop control variables and MANY MANY more.

Be afraid - be very afraid - remember Skynet? you may have succeeded in creating the first toolchanger to exhibit artificial intelligence.

Start again - this code is beyond help. Explain the mechanics you have and what you want it to do and I'm sure you'll get help.

Ian
« Last Edit: May 10, 2012, 05:07:16 AM by stirling » Logged

jewe
Active Member

Offline Offline

Posts: 8


View Profile
« Reply #11 on: May 15, 2012, 02:57:51 AM »

Hi Ian,

I remember Skynet, I'm one of their products... and you probably are John Connor :p
I need to be reprogrammed, without your intervention I'll destroy everything!

I changed the code to something more acceptable.
There are some "not yet used" variables, they should be used for security checks.
I understand why you're afraid...

Code update and comments will follow.

Thanks for your attention,

Jerome
Logged
stirling
Global Moderator
*
Offline Offline

Posts: 2,189

UK


View Profile WWW
« Reply #12 on: May 15, 2012, 03:58:53 AM »

I look forward to the challenge.... come tooled up  Wink

Ian
Logged

Pages: « 1 2   Go Up
Print
Jump to:  

Powered by MySQL Powered by PHP Powered by SMF 1.1.20 | SMF © 2013, Simple Machines Valid XHTML 1.0! Valid CSS!