Messages

631

Mach4 General Discussion / Re: Multiple inputs in LUA script

« on: October 12, 2016, 01:15:30 PM »

Also, where are you putting this script and how are you running it?

Seems to me the script Daz gave you would need to be in a function in the screen load script. Then you would make sure your inputs are setup in the sig lib in the screen load script so that when any of the inputs change states they would run that function.

632

Mach4 General Discussion / Re: Multiple inputs in LUA script

« on: October 12, 2016, 01:03:32 PM »

I realized earlier today that the script I inserted was the first capture and not completely correct as far as the inputs.  Here's the corrected script I've been testing.  I've tested the individual pins changing state with the Set RRO statement and it works fine.  And I've tried the below script with just two inputs and can't get it to work, so i'm thinking it's not the three inputs that's giving me a problem, I think there's something wrong in the wording of the script.

Code: [Select]

local Input14 = 0;
local Input15 = 0;
local Input17 = 0;
local hSig = 0;

hSig = mc.mcSignalGetHandle(inst, mc.ISIG_INPUT14);
Input14 = mc.mcSignalGetState(hSig);

hSig = mc.mcSignalGetHandle(inst, mc.ISIG_INPUT15);
Input15 = mc.mcSignalGetState(hSig);

hSig = mc.mcSignalGetHandle(inst, mc.ISIG_INPUT17);
Input17 = mc.mcSignalGetState(hSig);

if ((Input14 == 1) and (Input15 ==1) and (Input17 == 1)) then
    local inst = mc.mcGetInstance();
    mc.mcCntlSetRRO(inst, 100.0);
end
Bob

So what inputs are you using? 14,15,17 or 18,19,20?

Daz's script should work a treat but if your using different inputs edit the script so its looking at the right ones.

633

Mach4 General Discussion / Re: Multiple inputs in LUA script

« on: October 12, 2016, 12:56:11 PM »

Ok, here is the thing, in the call hSig = mc.mcSignalGetHandle(inst, mc.ISIG_INPUT18) inst is the first parameter required. What is inst? In your script it does not know because you have not defined it yet. You edited it to define it after it was needing defined. So any variable you are using for a parameter must be defined before using it.

The reason it works in the screen load script is because inst is defined at the very beginning of the screen load script.

inst as you can tell by the api call mc.mcGetInstance() is the instance of Mach. Because Mach4 can have multiple instances you need to know what instance you want to get or set. With the exception of a few, all api calls will use the instance parameter for the first parameter.

You only need to define it once within the scope of whatever it is your doing.

That error message is telling you exactly what is going on. It was looking for a number for the instance parameter (defined as mInst for Mach Instance in the api docs) but got a nil because the variable you were using for the instance ("inst") was not defined. All variables in lua are given the value of nil until you overwrite it with something else. So it got a nil when it was needing a number.

But listen, don't feel bad about this. I did this jut a week or so ago myself.    Tunnel vision may be the death of me. Thankfully another fella loaned me his eyes for a bit and caught it right off.

634

Mach4 General Discussion / Re: Multiple inputs in LUA script

« on: October 12, 2016, 08:07:38 AM »

Where are you defining the inst = mc.mcGetInstance(); before getting the hSig's?

635

FAQs / MOVED: Understanding spindle control in MACH3

« on: October 11, 2016, 11:50:47 AM »

This topic has been moved to General Mach Discussion.

http://www.machsupport.com/forum/index.php?topic=33375.0

636

Mach4 General Discussion / Re: Macro - Pause until input triggered

« on: September 30, 2016, 04:32:40 PM »

I am going to look at adding an error check module and the necessary bits to make it work in the default profiles. I have done it and tested it already and got it all working with some help from DTG. I had a very simple mistake and just kept overlooking it.    Garbage in is garbage out and I'm not immune from giving it some garbage myself. I think most when they start out coding have those moments when they want to kick their own butt. Happens to us all I think so remember that when your ready to give up.

Anyway, the m100 discussed earlier in this topic would like this after its all done. I like this much better..........

Code: [Select]

function m100()

local inst, hSig, rc
inst = mc.mcGetInstance()

hSig, rc = mc.mcSignalGetHandle(inst, mc.OSIG_OUTPUT1) -- Get handle for output 1
if (rc~= 0) then --Check our errors
mc.mcCntlSetLastError(inst, (mcErrorCheck[rc]))
                --wx.wxMessageBox(mcErrorCheck[rc]) --popup a message box with the error
end

rc = mc.mcSignalSetState(hSig, 1) --turn on output 1
if (rc~= 0) then --Check our errors
mc.mcCntlSetLastError(inst, (mcErrorCheck[rc]))
end

rc = mc.mcSignalWait(inst, mc.ISIG_INPUT21, 1, 5) --Wait 5 seconds for input 21 to become active
if (rc~= 0) then mc.mcCntlSetLastError(inst, (mcErrorCheck[rc])) end --In line check our errors works too

end

if (mc.mcInEditor() == 1) then
    m100()
end

637

Mach4 General Discussion / Re: Macro - Pause until input triggered

« on: September 28, 2016, 03:09:55 PM »

This should work. I changed the time to 5 seconds but you can adjust as needed.

Note, I have it putting the first checks in a MessageBox, the last 2 checks write them to the status bar or message bar in Mach. All of them write a message even if there is no error (MERROR_NOERROR).

Code: [Select]

function m100()

local inst, hSig, rc
inst = mc.mcGetInstance()
hSig, rc = mc.mcSignalGetHandle(inst, mc.OSIG_OUTPUT1) -- Get handle for output 1

if (rc == mc.MERROR_NOERROR) then
wx.wxMessageBox("MERROR_NOERROR")
elseif (rc == mc.MERROR_INVALID_INSTANCE) then
wx.wxMessageBox("MERROR_INVALID_INSTANCE")
elseif (rc == mc.MERROR_SIGNAL_NOT_FOUND) then
wx.wxMessageBox("MERROR_SIGNAL_NOT_FOUND")
end

rc = mc.mcSignalSetState(hSig, 1) --turn on output 1

if (rc == mc.MERROR_NOERROR) then
mc.mcCntlSetLastError(inst, "MERROR_NOERROR")
elseif (rc == mc.MERROR_INVALID_ARG) then
mc.mcCntlSetLastError(inst, "MERROR_INVALID_ARG")
end

rc = mc.mcSignalWait(inst, mc.ISIG_INPUT21, 1, 5) --Wait 5 seconds for input 21 to become active

if (rc == mc.MERROR_NOERROR) then
mc.mcCntlSetLastError(inst, "MERROR_NOERROR")
elseif (rc == mc.MERROR_INVALID_INSTANCE) then
mc.mcCntlSetLastError(inst, "MERROR_INVALID_INSTANCE")
elseif (rc == mc.MERROR_INVALID_ARG) then
mc.mcCntlSetLastError(inst, "MERROR_INVALID_ARG")
elseif (rc == mc.MERROR_NOT_ENABLED) then
mc.mcCntlSetLastError(inst, "MERROR_NOT_ENABLED")
elseif (rc == mc.MERROR_TIMED_OUT) then
mc.mcCntlSetLastError(inst, "MERROR_TIMED_OUT")
end
end

if (mc.mcInEditor() == 1) then
    m100()
end

638

Mach4 General Discussion / Re: Macro - Pause until input triggered

« on: September 28, 2016, 12:02:58 PM »

yay you lot have been busy, glad its working for you now.

DazTheGas

Thanks Daz!

I have not had a use for the mc.mcSignalWait API call yet so hadn't used it beofre but bet I will find a use for it real soon now.

Love it when a plan comes together! The devil is in the details. Thankfully the details are covered pretty good in the help file.

639

Mach4 General Discussion / Re: Macro - Pause until input triggered

« on: September 28, 2016, 11:55:11 AM »

Is there a simple way to pause motion until an input is triggered within a macro?  

I would like to ensure my Z axis returns home before the macro ends because after the macro would be an X-Y move. This is a cylinder where I have output 1 activate the "up" direction and output 0 activate the "down" direction.  

Something like this:

1. activate output_1 (up)
2. wait for Z home switch to trigger
3. end macro.

What is the best way to code step 2 (wait for input) in a Macro?

Good, thanks for testing!

This does not do any error checking and the time it waits for the input to go high is indefinite (neither of which are very good ideas) and it does not take your "In automatic Cycle" into account but it should be all that is needed to do what you were looking for originally.

Also note the 2 M100's were changed to m100 so should be saved as m100.mcs. Early on their was some debate about whether or not M codes should be upper or lower case in the scripts themselves. The answer is lower case. It should prevent some possible issues in non Windows OS's.

I would also delete any other M100 files (M100.mcs, M100.mcc, M100.bak) each time you edit the macro and before testing. If not, your changes may not take effect until you do.

Code: [Select]

function m100()
    
    local inst, hSig
    inst = mc.mcGetInstance()
    hSig = mc.mcSignalGetHandle(inst, mc.OSIG_OUTPUT1) -- Get handle for output 1
    
    mc.mcSignalSetState(hSig, 1) --turn on output 1
    mc.mcSignalWait(inst, mc.ISIG_INPUT21, 1, 0) --Wait indefinitely (0) for input 21 to become active
  
end

if (mc.mcInEditor() == 1) then
    m100()
end

640

Mach4 General Discussion / Re: Macro - Pause until input triggered

« on: September 28, 2016, 11:02:34 AM »

Nice, thanks!

Does this work as well?

Code: [Select]

function M100()
    
    local inst = mc.mcGetInstance()
    local input_20 = mc.mcSignalGetHandle(inst, mc.ISIG_INPUT20) -- Get handle for input 20
    local input_20_State = mc.mcSignalGetState(input_20) -- Get input 20 state
    
    if input_20 == 0 then
        wx.wxMessageBox("Could not locate signal!")

    else

        if input_20_State == 1 then --If input_20_State equals 1, then the signal is active.
            wx.wxMessageBox("Signal is already active!")

        else    --If input_20_State does not equal 1, then the signal is inactive.
            --wx.wxMessageBox("Setting input_20 high")
            mc.mcSignalSetState(input_20, 1)
   mc.mcSignalWait(inst, mc.ISIG_INPUT21, 1, 0)
        end
    end
end

if (mc.mcInEditor() == 1) then
    M100()
end
Also, just wondering what this is.........  mc.mcSignalSetState(input_20, 1)

Shouldn't that be turning on an output to fire the raise solenoid?